-
Notifications
You must be signed in to change notification settings - Fork 1.5k
e2e test helper script #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test helper script #2246
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cgchinmay! |
Hi @cgchinmay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2246 +/- ##
=======================================
Coverage 53.51% 53.51%
=======================================
Files 136 136
Lines 7605 7605
=======================================
Hits 4070 4070
Misses 3218 3218
Partials 317 317 Continue to review full report at Codecov.
|
d2da310
to
18e0365
Compare
Avoid abrupt script termination if there is an exception in ginkgo tests Fixed logging minor change
17893fd
to
e88bfee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgchinmay, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
* Added helper script to run e2e tests Avoid abrupt script termination if there is an exception in ginkgo tests Fixed logging minor change * renamed file Addressed PR comments * removed unnecessary code * Add VPC_ID as its needed to run ginkgo tests * fixed typo * Cordon off windows nodes * Add timeout for deletion of resources
Issue
N/A
Description
Added helper script to deploy load balancer controller and trigger e2e tests against a given cluster.
Needed script to run tests on prow
Checklist
Manually tested