-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adds parameter to create IngressClass Resource #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds parameter to create IngressClass Resource #2248
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @lazouz! |
Hi @lazouz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
93ad184
to
f3c2880
Compare
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
=======================================
Coverage 53.51% 53.51%
=======================================
Files 136 136
Lines 7605 7605
=======================================
Hits 4070 4070
Misses 3218 3218
Partials 317 317 Continue to review full report at Codecov.
|
Please update the chart version as well. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, lazouz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
import PR by @emanuelflp from aws/eks-charts#572
Description
To use the ingressClass parameter inside of Ingress resource, the IngressClass needs to be already exists in cluster.
This changes adds a new parameter to create ingressClass Resource.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯