-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for ALB IPv6 target groups #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
926130b
to
cd9dae5
Compare
033b0e5
to
94edb31
Compare
484af89
to
2beb7c5
Compare
Codecov Report
@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
+ Coverage 53.38% 54.22% +0.83%
==========================================
Files 136 136
Lines 7584 7716 +132
==========================================
+ Hits 4049 4184 +135
+ Misses 3219 3214 -5
- Partials 316 318 +2
Continue to review full report at Codecov.
|
2beb7c5
to
8efee2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Is this reflected in the docs? |
* Add support for ALB IPv6 target groups * Update CRDs * resolve VPC ENI for pods with IPv6 addresses * fix formatting * refactor based on PR comments
Issue
Description
Support IPv6 ALB target groups with the following prerequisites:
dualstack
ALBTargetgroupbinding CRD
Sample TargetGroupBinding spec with the IP address type
spec.ipAddressType
ipAddressType is an optional setting.
Load balancer configuration
IPv6 target groups are supported for dual stack load balancers. For ALB, dual-stack support can be configured via the following ingress annotation
For NLB, dual-stack support is configured via the following annotation
Service spec
For the auto-created target group bindings, the target group protocol is determined based on the service spec. The service
spec.ipFamilyPolicy
determines which IP protocol family to allow on the service configurationSingleStack
service can either be IPv6 or IPv4. This is the policy that will be supported in the initial phase.PreferDualStack
, configure IPv4 or IPv6 target groups based on configuration. [out of scope]RequireDualStack
, configure both IPv4 and IPv6 target groups. [out of scope]The immutable
spec.ipFamilies
field is used to specify which IP family to use for single-stack or the order of IP families for dual-stack.["IPv4"]
["IPv6"]
["IPv4","IPv6"]
(dual stack) [out-of-scope]["IPv6","IPv4"]
(dual stack) [out-of-scope]Listener rules
Listener rules forward traffic to either IPv4 target or IPv6 target based on the service configuration. Support for dual stack is currently out-of scope for this feature.
Limitations
Future Enhancements
Dual stack services will be supported once VPC CNI is able to setup dual-stack pods.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯