-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update service annotations live docs #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00c6c92
to
f423fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #2320 +/- ##
=======================================
Coverage 54.16% 54.16%
=======================================
Files 136 136
Lines 7698 7698
=======================================
Hits 4170 4170
Misses 3212 3212
Partials 316 316 Continue to review full report at Codecov.
|
Issue
#2318
#2296
#2184
Description
Document the service annotations supported by this controller.
Checklist
README.md
, or thedocs
directory)Manual tests
Ran
make docs-preview
and verified the live docs renders properly.BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯