Skip to content

Update anchor link of Nodeport from #nodeport to #type-nodeport #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Update anchor link of Nodeport from #nodeport to #type-nodeport #2348

merged 2 commits into from
Nov 17, 2021

Conversation

sandipanpanda
Copy link
Member

@sandipanpanda sandipanpanda commented Nov 9, 2021

Issue

Description

This PR updates the anchor links of Nodeport from https://kubernetes.io/docs/concepts/services-networking/service/#nodeport to https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport.

In kubernetes/website#30388 (comment), we can see that no. of files redirecting to #type-nodeport is 230, whereas for #nodeport it is only 31. Making changes to 230 files is though possible, but would take much toil. Hence, I found updating the latter to be an easy fix and practically feasible.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @sandipanpanda!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sandipanpanda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sandipanpanda
To complete the pull request process, please assign m00nf1sh after the PR has been reviewed.
You can assign the PR to them by writing /assign @m00nf1sh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sandipanpanda sandipanpanda changed the title Update anchor link from #nodeport to #type-nodeport in links Update anchor link of Nodeport from #nodeport to #type-nodeport Nov 9, 2021
@M00nF1sh
Copy link
Collaborator

/lgtm
But seems #type-nodeport is not available in upstream website yet, when will the k8s website switch the link?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@sandipanpanda
Copy link
Member Author

/lgtm But seems #type-nodeport is not available in upstream website yet, when will the k8s website switch the link?

The PR to switch the link to #type-nodeport has been merged kubernetes/website#30388.
This is the new link now: https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport

@M00nF1sh
Copy link
Collaborator

@sandipanpanda
Thanks so much, we'll update the docs after merging this

@M00nF1sh M00nF1sh merged commit db5fc12 into kubernetes-sigs:main Nov 17, 2021
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…rnetes-sigs#2348)

* Update anchor link from #nodeport to #type-nodeport in annotations.md

* Update anchor link from #nodeport to #type-nodeport in annotations.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants