-
Notifications
You must be signed in to change notification settings - Fork 1.5k
NLB Instance mode guide referenced the wrong annotation #2376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @TBBle! |
Hi @TBBle. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ooops, my CLA signature is under my work email address. I'll reset the author now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, TBBle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
None, noticed while reading the documentation.
Description
The annotation that takes an
instance
value isservice.beta.kubernetes.io/aws-load-balancer-nlb-target-type
, and this also matches the text we're being "similar to":Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯