-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding supports for unweighted target group through feature gate and checking SSL policy availability. #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @haouc! |
Hi @haouc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## main #2380 +/- ##
==========================================
- Coverage 53.87% 53.80% -0.07%
==========================================
Files 139 139
Lines 7802 7812 +10
==========================================
Hits 4203 4203
- Misses 3279 3289 +10
Partials 320 320
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haouc, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…checking SSL policy availability. (kubernetes-sigs#2380) * Adding supports for air gapped regions through feature gate. * Updated changes according to comments and changed feature gate to feature gates * Updates for configuration doc * Updated feature gates doc and key name
Issue
Description
In air gapped AWS regions, we need disable some features due to parity. We are using feature gate to manager this feature parity and also make them easily reversible.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯