Skip to content

Add default tags to backend SG #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2022
Merged

Add default tags to backend SG #2425

merged 2 commits into from
Jan 7, 2022

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Dec 22, 2021 •
edited
Loading

Issue

Fixes: #2424

Description

Add default-tags to the backend security group.

Tests

Verified backend SG contained additional tags specified in default-tags configuration.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #2425 (d4b676f) into main (2e181b2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
+ Coverage   53.35%   53.40%   +0.05%     
==========================================
  Files         140      140              
  Lines        7962     7971       +9     
==========================================
+ Hits         4248     4257       +9     
  Misses       3397     3397              
  Partials      317      317
Impacted Files Coverage Δ
pkg/config/controller_config.go 18.18% <ø> (ø)
pkg/networking/backend_sg_provider.go 91.20% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e181b2...d4b676f. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2021
@kishorj kishorj marked this pull request as ready for review December 22, 2021 22:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2021
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 22, 2021
@johngmyers
Copy link
Contributor

Shouldn't this use MergeStringMap() to reconcile overlapping tags, then pass to convertTagsToSDKTags()?

@johngmyers
Copy link
Contributor

johngmyers commented Dec 28, 2021 •
edited
Loading

Better yet, add elbv2.k8s.aws/resource to config.trackingTagKeys

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2022
@kishorj kishorj force-pushed the backend-sg-default-tag branch from d4b676f to a93737b Compare January 6, 2022 16:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2022
orsenthil
orsenthil approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, orsenthil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johngmyers
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@johngmyers
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit fee6232 into kubernetes-sigs:main Jan 7, 2022
This was referenced Feb 16, 2022
Closed
Merged
@kishorj kishorj deleted the backend-sg-default-tag branch February 18, 2022 18:35
@johngmyers johngmyers mentioned this pull request Jan 24, 2023
Merged
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
Merged
12 tasks
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@kishorj @Timothy-Dougherty
Add default tags to backend SG (kubernetes-sigs#2425)
22ecd4e 
* Add default tags to backend SG

* update controller configurations doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to tag security group with default-tags
5 participants
@kishorj @k8s-ci-robot @codecov-commenter @johngmyers @orsenthil