Skip to content

Fetch aws-load-balancer-controller logs before deleting #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2022
Merged

Fetch aws-load-balancer-controller logs before deleting #2436

merged 3 commits into from
Jan 19, 2022

Conversation

cgchinmay
Copy link
Contributor

Issue

NA

Description

Fetch controller logs before deleting it inside the e2e helper script

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cgchinmay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2436 (bd91533) into main (2e181b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2436   +/-   ##
=======================================
  Coverage   53.35%   53.35%           
=======================================
  Files         140      140           
  Lines        7962     7962           
=======================================
  Hits         4248     4248           
  Misses       3397     3397           
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e181b2...bd91533. Read the comment docs.

kishorj
kishorj reviewed Jan 5, 2022
View reviewed changes
test/e2e/run-canary-test.sh Outdated
@@ -78,6 +78,9 @@ echo "Starting the ginkgo test suite"

(cd $SCRIPT_DIR && CGO_ENABLED=0 GOOS=$OS_OVERRIDE ginkgo -v -r --timeout 60m --failOnPending -- --kubeconfig=$KUBE_CONFIG_PATH --cluster-name=$CLUSTER_NAME --aws-region=$REGION --aws-vpc-id=$VPC_ID || true)

echo "Fetch most recent aws-load-balancer-controller logs"
kubectl logs --tail=100 deploy/aws-load-balancer-controller -n kube-system
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get the logs from all the controller pods using the selector -l app.kubernetes.io/name=aws-load-balancer-controller. Any reason to limit to 100 lines?

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgchinmay, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@kishorj kishorj merged commit 8974bd4 into kubernetes-sigs:main Jan 19, 2022
This was referenced Feb 16, 2022
Closed
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@Timothy-Dougherty
Fetch aws-load-balancer-controller logs before deleting (kubernetes-s…
6f7e8f8 
…igs#2436)

* Fetch aws-load-balancer-controller logs before deleting

* Fetch logs from all controller pods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgchinmay @k8s-ci-robot @codecov-commenter @kishorj