-
Notifications
You must be signed in to change notification settings - Fork 1.5k
helm: Create IngressClass by default #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Create IngressClass by default #2442
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2442 +/- ##
=======================================
Coverage 53.37% 53.37%
=======================================
Files 140 140
Lines 7966 7966
=======================================
Hits 4252 4252
Misses 3397 3397
Partials 317 317 Continue to review full report at Codecov.
|
c8df36e
to
c48694f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Description
Create the
IngressClass
by default. Now that the minimum supported Kubernetes version supports theIngressClass
kind, there are few if any downsides to provisioning them.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯