Add an option to disable SG rules management for NLB #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
kishorj
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
needs-rebase
kishorj
force-pushed
the
disable-sg-rules
branch
from
3cb8fee to
789d7a8
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 16, 2022
tyen-brex
reviewed
Mar 19, 2022
| @@ -46,6 +46,7 @@ | |||
| | [service.beta.kubernetes.io/aws-load-balancer-alpn-policy](#alpn-policy) | stringList | | | | |||
| | [service.beta.kubernetes.io/aws-load-balancer-target-node-labels](#target-node-labels) | stringMap | | | | |||
| | [service.beta.kubernetes.io/aws-load-balancer-attributes](#load-balancer-attributes) | stringMap | | | | |||
| | [service.beta.kubernetes.io/aws-load-balancer-manage-backend-security-group-rules](#manage-backend-sg-rules) | boolean | false | | | |||
There was a problem hiding this comment.
default is true, I'll fix the doc, thanks.
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2358
Description
Provide a mechanism to configure SG rules management per service via the following annotation
If set to
"false", the controller will not add ingress rules to the EC2 instance/ENI security group for traffic and health check access. This feature is useful in case users have services with a lot of ports or multiple services and the individual SG ingress rules would hit the AWS SG rules quota. If disabled, users would have to add the rules for traffic and health check manually. If the annotation is not specified, the default value is"true".Manual tests
Created a service with the annotation
service.beta.kubernetes.io/aws-load-balancer-manage-backend-security-group-rules: "false", and verified the EC2 instance SG did not contain the ingress rules for the service ports.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯