-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add support for loadBalancerClass #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for loadBalancerClass #2489
Conversation
Skipping CI for Draft Pull Request. |
042e39c
to
f4ba71d
Compare
i think we can use service.k8s.aws/nlb to align with our IngressClass's ingress.k8s.aws/alb name. also it denotes it's a NLB :D |
632addb
to
982eb05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
==========================================
+ Coverage 53.38% 53.51% +0.13%
==========================================
Files 140 142 +2
Lines 7988 8026 +38
==========================================
+ Hits 4264 4295 +31
- Misses 3406 3412 +6
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add support for loadBalancerClass * throw error in case of unallocated NodePort * centralize IsServiceSupported logic * handle lb type annotation change for type LoadBalancer * refactor IsServiceSupported
Issue
Fixes: #2466
Fixes: #2492
Description
Add support for service
spec.loadBalancerClass
. The load balancer class provides a similar mechanism to the current service annotationservice.beta.kubernetes.io/aws-load-balancer-type: "external"
to offload reconciling of load balancer from the kubernetes in-tree controller, but it is agnostic to the cloudprovider - KEP-1959 for details. The load balancer class is beta starting k8s 1.22.The AWS Load Balancer controller will support the
spec.loadBalancerClass
starting v2.4.0 on k8s 1.22 and later. Here is the summary of the changesservice.k8s.aws/nlb
, users can modify via controller command line flag--load-balancer-class
spec.loadBalancerClass
, users no longer need to specify the annotationservice.beta.kubernetes.io/aws-load-balancer-type
on k8s 1.22 and laterinstance
for service with loadBalancerClass specified on supported k8sServiceTypeLoadBalancerOnly
which limits the controller to service of type LoadBalancer for NLBTests:
spec.loadBalancerClass
configuration on k8s 1.22Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯