Make e2e LB name test work with clusters that have . in the name

[olemarkus]

Description

ELB names cannot have . in the name, but cluster names can. So when the load-balancer-name annotation e2e test directly copies cluster name into the ELB name, the test fails.

This PR replaces . with - to make tests pass.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[codecov-commenter]

Codecov Report

Merging #2516 (7330bd1) into main (694a0b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2516   +/-   ##
=======================================
  Coverage   53.52%   53.52%           
=======================================
  Files         142      142           
  Lines        8039     8039           
=======================================
  Hits         4303     4303           
  Misses       3414     3414           
  Partials      322      322           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694a0b1...7330bd1. Read the comment docs.

[kishorj]

Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kishorj]

/lgtm