Auto generate CRDs for the Helm chart #2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k8s-ci-robot
added
the
cncf-cla: no
k8s-ci-robot
added
approved
Co-authored-by: Fawad Khaliq <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## main #2517 +/- ##
=======================================
Coverage 53.52% 53.52%
=======================================
Files 142 142
Lines 8039 8039
=======================================
Hits 4303 4303
Misses 3414 3414
Partials 322 322 Continue to review full report at Codecov.
|
kishorj
added
the
tide/merge-method-squash
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
6 tasks
thejasn
pushed a commit
to thejasn/aws-load-balancer-controller
that referenced
this pull request
Apr 7, 2022
* Auto generate CRDs for the Helm chart Co-authored-by: Fawad Khaliq <[email protected]> * Makefile changes * fix kustomize install Co-authored-by: Fawad Khaliq <[email protected]>
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
* Auto generate CRDs for the Helm chart Co-authored-by: Fawad Khaliq <[email protected]> * Makefile changes * fix kustomize install Co-authored-by: Fawad Khaliq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2087
Description
Auto generate CRDs for the Helm chart. Also added a make target to install kustomize(if missing).
PR to merge changes from #2087
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯