Skip to content

[Doc] Update migrate_v1_v2 document #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

yws-ss
Copy link
Contributor

@yws-ss yws-ss commented Mar 22, 2022

Issue

Update the migration document. Currently, the new version link is using version "2.4.1". However, the document still mention "2.0.1". Update this to avoid misunderstanding.

Description

Change the document description:

Upgrade steps --> Install new AWSLoadBalancerController --> Install AWSLoadBalancerController(v2.0.1) by following the installation instructions

to

Upgrade steps --> Install new AWSLoadBalancerController --> Install AWSLoadBalancerController(v2.4.1) by following the installation instructions

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 22, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yws-ss!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yws-ss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2022
@yws-ss yws-ss changed the title Update migrate_v1_v2.md [Doc] Update migrate_v1_v2.md Mar 22, 2022
@yws-ss yws-ss changed the title [Doc] Update migrate_v1_v2.md [Doc] Update migrate_v1_v2 document Mar 22, 2022
@kishorj
Copy link
Collaborator

kishorj commented Mar 22, 2022

@yws-ss, thanks for your contribution. Please sign the CNCF CLA before I can merge your changes,

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 22, 2022
@yws-ss
Copy link
Contributor Author

yws-ss commented Mar 22, 2022

@yws-ss, thanks for your contribution. Please sign the CNCF CLA before I can merge your changes,

Hello @kishorj , I have done the CNCF CLA. Thanks for your remind.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, yws-ss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2573 (12d3de1) into main (9604877) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2573   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files         144      144           
  Lines        8165     8165           
=======================================
  Hits         4397     4397           
  Misses       3451     3451           
  Partials      317      317           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1646a0d...12d3de1. Read the comment docs.

@kishorj kishorj merged commit f014735 into kubernetes-sigs:main Mar 22, 2022
thejasn pushed a commit to thejasn/aws-load-balancer-controller that referenced this pull request Apr 7, 2022
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants