helm: add deployment annotation

[krrrr38]

Signed-off-by: krrrr38 [email protected]

Issue

Some crd / tools requires deployment annotations.

Description

Add deployment annotation values into aws-load-balancer-controller helm chart.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

Testing

with annotations

> helm template . | \grep -A10 -B3 "kind: Deployment"
---
# Source: aws-load-balancer-controller/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: RELEASE-NAME-aws-load-balancer-controller
  namespace: default
  annotations:
    a1: b1
    a2: b2
  labels:
    helm.sh/chart: aws-load-balancer-controller-1.4.1
    app.kubernetes.io/name: aws-load-balancer-controller
    app.kubernetes.io/instance: RELEASE-NAME

without annotations

> helm template . | \grep -A10 -B3 "kind: Deployment"
---
# Source: aws-load-balancer-controller/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: RELEASE-NAME-aws-load-balancer-controller
  namespace: default
  labels:
    helm.sh/chart: aws-load-balancer-controller-1.4.1
    app.kubernetes.io/name: aws-load-balancer-controller
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "v2.4.1"
    app.kubernetes.io/managed-by: Helm
spec:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: krrrr38 / name: Ken Kaizu (700615363dfaa69631ca1daabf10b3e0a5748eb2)

[k8s-ci-robot]

Welcome @krrrr38!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @krrrr38. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

Also update the README.md file for the new value

[kishorj]

Please add a comment for this value, something like:

# deploymentAnnotations contains additional annotations for the controller deployment
deploymentAnnotations: {}

[krrrr38]

Added comment, test.values and REAME.md

e2fe042

[codecov-commenter]

Codecov Report

Merging #2611 (e2fe042) into main (c1b9579) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2611   +/-   ##
=======================================
  Coverage   53.95%   53.95%           
=======================================
  Files         144      144           
  Lines        8196     8196           
=======================================
  Hits         4422     4422           
  Misses       3455     3455           
  Partials      319      319           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b9579...e2fe042. Read the comment docs.

[kishorj]

/ok-to-test

[kishorj]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, krrrr38

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kishorj]

/retest