Add imagePullSecrets option to ServiceAccount in helm chart

[BrianKopp]

Description

This PR adds the ability to configure the ServiceAccount to have imagePullSecrets for docker secrets to authenticate against docker registries. This is for the aws-load-balancer-controller chart.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Welcome @BrianKopp!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @BrianKopp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

default should be empty

[BrianKopp]

Shoot, I left this on for testing that the values piped through correctly. I've updated the values and comments as you've suggested.

[kishorj]

How about this for the comment and the value:

# imagePullSecrets specifies the list of image pull secrets to add to the ServiceAccount
imagePullSecrets:
    # - name: docker

[BrianKopp]

Updated!

[kishorj]

Thanks

[codecov-commenter]

Codecov Report

Merging #2624 (36687ae) into main (dd57d47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2624   +/-   ##
=======================================
  Coverage   53.94%   53.94%           
=======================================
  Files         144      144           
  Lines        8197     8197           
=======================================
  Hits         4422     4422           
  Misses       3456     3456           
  Partials      319      319           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57d47...36687ae. Read the comment docs.

[kishorj]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BrianKopp, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kishorj]

/lgtm