Skip to content

e2e test changes to support china regions #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2022
Merged

e2e test changes to support china regions #2723

merged 3 commits into from
Jul 16, 2022

Conversation

cgchinmay
Copy link
Contributor

Issue

NA

Description

Cannot run e2e tests in china region. The color teller application image is region specific so running e2e tests in china fails to pull this image. So moved this image to public docker registry so that it can be pulled in china region.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cgchinmay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from kishorj and M00nF1sh July 8, 2022 23:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #2723 (3844b07) into main (d8ee617) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2723   +/-   ##
=======================================
  Coverage   53.99%   53.99%           
=======================================
  Files         144      144           
  Lines        8214     8214           
=======================================
  Hits         4435     4435           
  Misses       3461     3461           
  Partials      318      318

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ee617...3844b07. Read the comment docs.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2022
@cgchinmay cgchinmay changed the title Use Colorteller application image from public docker registry e2e test changes to support china regions Jul 15, 2022
kishorj
kishorj reviewed Jul 15, 2022
View reviewed changes
kishorj
kishorj reviewed Jul 15, 2022
View reviewed changes
test/framework/manifest/fixed_response_service_builder.go Outdated
@@ -93,7 +95,7 @@ func (b *fixedResponseServiceBuilder) buildDeployment(namespace string, name str
Containers: []corev1.Container{
{
Name: "app",
Image: "970805265562.dkr.ecr.us-west-2.amazonaws.com/colorteller:latest",
Image: utils.COLORTELLER_IMAGE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want to replace all instances of the ECR repo 970805265562? Could you verify if there are other tests that don't work due to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run all tests under e2e, didn't have any issues

@kishorj
Copy link
Collaborator

kishorj commented Jul 16, 2022

/lgtm
/approve

@kishorj
Copy link
Collaborator

kishorj commented Jul 16, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgchinmay, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit ed1f080 into kubernetes-sigs:main Jul 16, 2022
@kishorj kishorj mentioned this pull request Aug 10, 2022
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@Timothy-Dougherty
e2e test changes to support china regions (kubernetes-sigs#2723)
7116e73 
* Use Colorteller application image from public docker registry

* Updated e2e test runner script to support china regions

* Updated ColortellerImage tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj left review comments

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgchinmay @k8s-ci-robot @codecov-commenter @kishorj