fix failures during upgrade when using the default provided IngressClass and IngressClassParam

[M00nF1sh]

Issue

#2731

Description

This change will disable usage of IngressClassParams in the default provided "alb" IngressClass by default(unless the IngressClassParams have name/spec customized)

The IngressClassParams will continue to be created by default as well to avoid potential race conditions while update from a version that were already using the alb IngressClassParams

Also, if IngressClassParams is been used by IngressClass, the change will create the IngressClassParams first[this is not 100% safe since Kubernetes don't guarantee controllers receive events about different objects in order, a controller change is needed for it, see #2731]

The IngressClassParams will only be used by the default provided "alb" IngressClass when one of following condition is true:

1. IngressClassParams.create == false and IngressClassParams.name != "", this means the "alb" IngressClass will be configured to use a pre-exists IngressClassParams.
2. IngressClassParams.create == false and (IngressClassParams.name != "" or IngressClassParams.spec != {}), this means the "alb" IngressClass will be configured to use a new created IngressClassParams that have customizations. (otherwise, there is no need to make alb IngressClass reference the IngressClassParams if there is no customization)

Upgrade scenarios:

• For users with helmChart version < v1.3.1:
  • currently they have no default-provided IngressClass nor IngressClassParams
  • after upgrade to version with this fix, there will be alb IngressClass and alb IngressClassParams created, and the alb is not configured to use the alb IngressClassParams. [this is safe]
• For users with helmChart version 1.3.1-1.3.3
  • currently they have the default provided "alb" IngressClass.
  • after upgrade to version with this fix under default configurations, the default provided "alb" IngressClass will have no change, while a new "alb" IngressClassParams will be created but not used. [this is safe]
  • after upgrade to version with this fix while override the newly provided ingressClassParams.spec, the default provided "alb" IngressClass will be configured to use the newly created "alb" IngressClassParam after its creation. [in theory this may not be safe, but should be fine as we don't expect users to explicitly modify the default provided IngressClassParams while have Ingresses currently using it]
• For users with helmChart version 1.4.0-1.4.2
  • currently they have the default-provided alb IngressClass and alb IngressClassParams
  • after upgrade to version with this fix under default configurations, the default provided "alb" IngressClass will be modified to no longer use the alb IngressClassParams. [this is safe since using a IngressClassParams without configuration is same as don't use IngressClassParams]
  • after upgrade to version with this fix while while override the newly provided ingressClassParams.spec, no change will done.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[kishorj]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [M00nF1sh,kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment