Skip to content

Enhance client side throttling information #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2022
Merged

Enhance client side throttling information #2739

merged 3 commits into from
Jul 28, 2022

Conversation

orsenthil
Copy link
Member

Enhance client side throttling information

Issue

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@orsenthil
Enhance client side throttling information
1524f5a 
Enhance client side throttling information
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot requested review from kishorj and M00nF1sh July 27, 2022 19:54
kishorj
kishorj reviewed Jul 27, 2022
View reviewed changes
M00nF1sh
M00nF1sh approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2739 (fbc96e7) into main (2edc214) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2739   +/-   ##
=======================================
  Coverage   53.99%   53.99%           
=======================================
  Files         144      144           
  Lines        8214     8214           
=======================================
  Hits         4435     4435           
  Misses       3461     3461           
  Partials      318      318

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edc214...fbc96e7. Read the comment docs.

@k8s-ci-robot
Copy link
Contributor

@orsenthil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-load-balancer-controller-unit-test fbc96e7 link true /test pull-aws-load-balancer-controller-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 28, 2022
@kishorj kishorj merged commit f377486 into kubernetes-sigs:main Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh, orsenthil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kishorj kishorj mentioned this pull request Aug 10, 2022
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@orsenthil @kishorj @Timothy-Dougherty
Enhance client side throttling information (kubernetes-sigs#2739)
31da570 
* Enhance client side throttling information

Enhance client side throttling information

* Update docs/deploy/configurations.md

Thank you.

Co-authored-by: Kishor Joshi <[email protected]>

* Update configurations.md

Co-authored-by: Kishor Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@M00nF1sh M00nF1sh M00nF1sh approved these changes

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orsenthil @codecov-commenter @k8s-ci-robot @kishorj @M00nF1sh