use a dedicated config to disable default pod affinity #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
kishorj
added
tide/merge-method-squash
k8s-ci-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## main #2743 +/- ##
=======================================
Coverage 53.99% 53.99%
=======================================
Files 144 144
Lines 8214 8214
=======================================
Hits 4435 4435
Misses 3461 3461
Partials 318 318 Continue to review full report at Codecov.
|
M00nF1sh
reviewed
Jul 29, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
revert changes from PR kubernetes-sigs#2576
kishorj
force-pushed
the
default-affinity-config
branch
from
1de7990 to
b66b48a
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
/retest |
kishorj
added
the
lgtm
|
/lgtm |
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
) revert changes from PR kubernetes-sigs#2576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Alternate fix for issue #2570
Description
This PR revert changes from #2576 and adds a separate helm value
configureDefaultAffinitywhich controls whether to use the default affinity configuration for the controller pods. This value is true by default, so there is no changes in the behavior from prior version. In case of custom affinity configuration, this value gets ignored.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯