-
Notifications
You must be signed in to change notification settings - Fork 1.5k
alpn-policy accept only string and not alpn-policy #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @BouchaaraAdil! |
Hi @BouchaaraAdil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BouchaaraAdil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
thanks for fixing this 😄 |
Issue
fix typo documentation
service.beta.kubernetes.io/aws-load-balancer-alpn-policy
Description
we tended to use the annotation as a list to accept different policies and map them to listeners,
but while applying we got an error that it accepts only one value of
[HTTP1Only, HTTP2Only, HTTP2Optional, HTTP2Preferred, None]
it would be nice if we have an annotation which accepts different alpn policies and not only one
something like
service.beta.kubernetes.io/aws-load-balancer-alpn-policies
with type StringMap so then we assign port to each alpn policy