-
Notifications
You must be signed in to change notification settings - Fork 1.5k
update external dns manifest and docs #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice! Thanks for making this doc change @kishorj /lgtm |
@shyamjvs: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 54.05% // Head: 54.05% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 144 144
Lines 8278 8278
=======================================
Hits 4475 4475
Misses 3479 3479
Partials 324 324 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Issue
External DNS example is out of date.
Description
Update external-dns sample manifest and docs.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯