-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: make external-dns optional in echoserver walkthrough #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @prasadkatti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 54.09% // Head: 54.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 144 144
Lines 8291 8291
=======================================
Hits 4485 4485
Misses 3479 3479
Partials 327 327 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -143,8 +144,7 @@ In this walkthrough, you'll | |||
alb.ingress.kubernetes.io/tags: Environment=dev,Team=test | |||
spec: | |||
rules: | |||
- host: echoserver.example.com | |||
http: | |||
- http: | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is off here. Could you fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was actually off before. I fixed it here. Reference - https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#ingressrule-v1-networking-k8s-io. The keys host
and http
need to be at the same indent level.
/ok-to-test |
Co-authored-by: John Gardiner Myers <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, prasadkatti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…s-sigs#2950) * docs: make external-dns optional in echoserver walkthrough * Update link to external-dns Co-authored-by: John Gardiner Myers <[email protected]> Co-authored-by: John Gardiner Myers <[email protected]>
Description
This PR updates the
echoserver
walkthrough.external-dns
is completely optional.external-dns
is not usedspec.rules[0].host
in the default manifest. With this in, the example does not work if external-dns is not used. The listener rule does not match because the Host Header does not match the ALB DNS name.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯