Skip to content

cut v2.4.6 release #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Jan 11, 2023

Issue

Description

cut v2.4.6 release

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2023
@kishorj kishorj requested a review from M00nF1sh January 11, 2023 01:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2023
@kishorj kishorj added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 54.09% // Head: 54.07% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9c6ae1e) compared to base (73f1dc0).
Patch coverage: 53.48% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
- Coverage   54.09%   54.07%   -0.02%     
==========================================
  Files         144      144              
  Lines        8291     8301      +10     
==========================================
+ Hits         4485     4489       +4     
- Misses       3479     3484       +5     
- Partials      327      328       +1     
Impacted Files Coverage Δ
pkg/config/feature_gates.go 0.00% <0.00%> (ø)
pkg/deploy/stack_deployer.go 0.00% <0.00%> (ø)
pkg/deploy/elbv2/target_group_synthesizer.go 51.04% <50.00%> (-2.15%) ⬇️
pkg/service/model_build_target_group.go 85.67% <75.00%> (-0.30%) ⬇️
pkg/service/model_builder.go 88.17% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4bba8f5 into kubernetes-sigs:main Jan 12, 2023
type: object
type: object
x-kubernetes-map-type: atomic

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask what purpose it serves to add this into the template? Is it a dependency of something? I don't see anything in the README about it.

Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants