Add docker-push-w-buildx make target

[ivyostosh]

Issue

N/A

Description

Repo aws-load-balancer-controller has chosen to use ko for container image build by default. This PR gives users an option to use docker buildx with customization on BUILD_IMAGE and BASE_IMAGE.

Having a fixed BUILD_IMAGE and BASE_IMAGE meaning building binary and images all in a controlled environment, which allows easier CVE management where a user can monitor BUILD_IMAGE and BASE_IMAGE constantly.

Note this is created to support internal pipelines since we want to be able to choose both golang and base image versions.

Checklist

• N/A Added tests that cover your change (if possible)
• N/A Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• N/A Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Welcome @ivyostosh!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ivyostosh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

Any specific reason we want to use docker?

[kishorj]

This might not be compatible with the new deployment manifest corresponding to the ko image.

Since this changes doesn't influence e2e tests, please verify whether the container image is compatible with the manifest/helm chart from the main branch.

[ivyostosh]

Confirmed the deployment spec will be compatible with both the docker and the ko images. Note this change is created to support internal pipelines since we want to be able to choose both golang and base image versions.

[kishorj]

With ko, we can specify the base image in the .ko.yaml file

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ecd10c) 54.72% compared to head (4f227d7) 54.72%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3135   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files         145      145           
  Lines        8477     8477           
=======================================
  Hits         4639     4639           
  Misses       3503     3503           
  Partials      335      335           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kishorj]

This image has known vulnerabilities,
please use
public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base-nonroot:2023-02-22-1677092456.2

[ivyostosh]

Thanks. Updated

[kishorj]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivyostosh, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kishorj]

/lgtm