add objectSelector to the new controller webhooks #3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service mutator and ingressclassparams validator webhooks ignore the services and the ingressclassparams resources included in the controller manifest. The webhook service is of type ClusterIP and need not be mutated by the webhook. This change resolves the cyclic dependency between the service and the mutator webhook. In the long term we will use the `matchConditions` once `AdmissionWebhookMatchConditions` feature is GA. As for the `ingressclassparams`, the webhook might not be available during chart install/upgrade time causing the operation to fail. This is a short term fix to get backward compatible behavior.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
kishorj
added
tide/merge-method-squash
kishorj
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
=======================================
Coverage 54.73% 54.73%
=======================================
Files 145 145
Lines 8479 8479
=======================================
Hits 4641 4641
Misses 3503 3503
Partials 335 335 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fluxcd users reported issues installing/upgrading the controller chart version 1.5.1 due to
vingressclassparams.elbv2.k8s.awswebhook errors.Description
The service mutator and ingressclassparams validator webhooks ignore the services and the ingressclassparams resources included in the controller manifest.
The webhook service is of type ClusterIP and need not be mutated by the webhook. This change resolves the cyclic dependency between the service and the mutator webhook. In the long term we will use the
matchConditionsonceAdmissionWebhookMatchConditionsfeature is GA.As for the
vingressclassparams.elbv2.k8s.aws, ignoring theingressclassparamsresource included in the chart allows the install/upgrade to succeed. This is a short term fix to get backward compatible behavior, we will deprecate the default ingressclassparams resource included in the chart in future releases.Tests
flux create helmreleasefor chart version 1.5.2, no prior installationChecklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯