Skip to content

Add validation for vpcID in tgb spec #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2024
Merged

Add validation for vpcID in tgb spec #3663

merged 4 commits into from
May 7, 2024

Conversation

shraddhabang
Copy link
Collaborator

Description

Add validation for vpcID in tgb spec

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2024
oliviassss
oliviassss reviewed May 1, 2024
View reviewed changes
webhooks/elbv2/targetgroupbinding_validator_test.go Outdated
args: args{
tgb: &elbv2api.TargetGroupBinding{
Spec: elbv2api.TargetGroupBindingSpec{
TargetGroupARN: "tg-2",
TargetType: &ipTargetType,
VpcID: "vpc-02",
VpcID: "vpc-vpc-0bbbbbbb",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean vpc-0bbbbbbb?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixed it. Apologies

@shraddhabang
Copy link
Collaborator Author

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.41%. Comparing base (b44633a) to head (57a49d9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3663   +/-   ##
=======================================
  Coverage   55.40%   55.41%           
=======================================
  Files         151      151           
  Lines        9144     9146    +2     
=======================================
+ Hits         5066     5068    +2     
  Misses       3736     3736           
  Partials      342      342

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 6, 2024
@oliviassss
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@oliviassss oliviassss merged commit 5df1ab7 into kubernetes-sigs:main May 7, 2024
1 check was pending
@wweiwei-li wweiwei-li mentioned this pull request May 17, 2024
Merged
@khizunov khizunov mentioned this pull request Sep 4, 2024
Open
@khizunov
Copy link
Contributor

khizunov commented Sep 4, 2024

@shraddhabang @oliviassss Can you please explain the purpose of this PR? It seems unnecessary and its breaking k8s running on AWS API compatible clouds. If it is indeed necessary I would like to implement #3839. Please let me know WDYT

@khizunov khizunov mentioned this pull request Sep 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviassss oliviassss oliviassss left review comments

@kishorj kishorj Awaiting requested review from kishorj

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shraddhabang @codecov-commenter @oliviassss @k8s-ci-robot @khizunov