-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add dualstack without public IPv4 IP Address type #3688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dualstack without public IPv4 IP Address type #3688
Conversation
Hi @wweiwei-li. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
1804dde
to
c8d6aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, shraddhabang, wweiwei-li The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Application Load Balancer now allows customers to disable public IPv4 on their internet facing dualstack ALB. To support this on controller, adding a new IpAddressType enum,
dualstack-without-public-ipv4
, to allow controller users to choose a dualstack ALB without public IPv4 when setting up a new ALB, or switch to dual-stack without public IPv4 for an existing ALB.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯