keep LB addons' settings unchanged unless explicitly specified #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
M00nF1sh
force-pushed
the
lb_addon_explicitly_disable
branch
from
e708278 to
b8ffe02
Compare
add UTs for related components
M00nF1sh
force-pushed
the
lb_addon_explicitly_disable
branch
from
b8ffe02 to
e0dc87d
Compare
k8s-ci-robot
added
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, oliviassss, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
M00nF1sh
added a commit
to M00nF1sh/aws-load-balancer-controller
that referenced
this pull request
Aug 9, 2024
…netes-sigs#3800) add UTs for related components
6 tasks
M00nF1sh
added a commit
that referenced
this pull request
Aug 9, 2024
* bump up go to 1.22.5 (#3798) * keep LB addons' settings unchanged unless explicitly specified (#3800) add UTs for related components --------- Co-authored-by: Olivia Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #3780
Description
This PR changes the behavior of annotations related to Application LoadBalancer add-ons:
alb.ingress.kubernetes.io/waf-acl-idalb.ingress.kubernetes.io/wafv2-acl-arnalb.ingress.kubernetes.io/shield-advanced-protectionPrevious, when those annotations is not specified, the controller will make sure those add-ons don't exists on loadBalancer, i.e. delete all existing WAFClassic/WAFv2/ShieldProtection.
We have decided to change the behavior such that if those annotations is not specified or empty, the controller will keep the existing add-ons(if any) unchanged. And users have to explicitly disable add-ons via annotations:
alb.ingress.kubernetes.io/waf-acl-id: nonealb.ingress.kubernetes.io/wafv2-acl-arn: nonealb.ingress.kubernetes.io/shield-advanced-protection: falseChecklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯