Skip to content

Fixed attribute logic #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Fixed attribute logic #441

merged 2 commits into from
Jun 28, 2018

Conversation

bigkraig
Copy link

There were a few problems with how load balancer attributes were managed, I also cleaned up some logging messages during the reconcile and removed a duplicate method for configuring the idle timeout. Resolves #440

…butes and set up some default attribute filtering to only compare non-default values.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2018
@bigkraig bigkraig merged commit 39cde7f into master Jun 28, 2018
@bigkraig bigkraig deleted the fix-attributes branch June 28, 2018 23:49
bigkraig added a commit that referenced this pull request Oct 1, 2018
@ianau74
Copy link

ianau74 commented Mar 4, 2019

How does one set the connection timeout of the ALB?

In the docs, https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/ingress/annotation/#load-balancer-attributes it says you're supposed to use:

alb.ingress.kubernetes.io/load-balancer-attributes:idle_timeout.timeout_seconds: "120"

But, that shows:
metadata.annotations: Invalid value: "alb.ingress.kubernetes.io/load-balancer-attributes:idle_timeout.timeout_seconds": name part must consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9]')

@ianau74
Copy link

ianau74 commented Mar 4, 2019

Ah, nevermind. The correct syntax is:
alb.ingress.kubernetes.io/load-balancer-attributes: idle_timeout.timeout_seconds=3600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants