-
Notifications
You must be signed in to change notification settings - Fork 1.5k
adding helm-repo as github pages #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@M00nF1sh I get an error while trying to install
the correct command is:
and to check if the alb-ingress-controller is installed:
|
I realized when I installed the chart like this:
The installation works, but the deployment name will be:
The name contains a lot of redundant terms. |
Hi, do you have suggestions for this 😄 , currently the deployment name is generated as 'releaseName-alb-ingress-controller'. I noticed other projects like helm used similar name pattern.. |
The "helm create" command in 2.11.0 has updated the default _helpers.tpl functions which will address that redundancy. It also has different default labels. We may want to consider recreating the chart with helm 2.11.0. |
Nice! I'll recreate the helm chart. |
Most charts that i've seen dont specify a namespace in their resource templates, allowing users to specify a namespace in their |
I agree with @rifelpet, I would not specify the kube-system namespace in the template, but what is important for me is to be able to set the name and the namespace to what I want. |
Cool! Then an example usage in README.md should be enough, thanks for the explanation! 👍 |
/lgtm |
Changes done:
Test done:
An helm repo build via
make docs-deploy
, which contains different versions of alb-ingress-controller-helm: https://m00nf1sh.github.io/aws-alb-ingress-controllerHow to install:
helm repo add aws-alb https://m00nf1sh.github.io/aws-alb-ingress-controller
helm repo update
helm repo install aws-alb/alb-ingress-controller-helm --name=test --set extraArgs.v=1
orhelm repo install aws-alb/alb-ingress-controller-helm --version=0.1.3 --name=test --set extraArgs.v=1
Source code of helm-repo plugin:
https://github.com/M00nF1sh/mkdocs-helm
Future work: