Skip to content

Documentation Fixes & Remove helm repo plugin #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2018
Merged

Documentation Fixes & Remove helm repo plugin #787

merged 2 commits into from
Dec 18, 2018

Conversation

M00nF1sh
Copy link
Collaborator

Changes done:

  1. Remove the unneeded helm repo plugin
  2. Adding example for enable sticky sessions(fix Any way to specify healthCheckPath and healthCheckStatus on a per path basis? #784)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2018
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit f3bc481 into kubernetes-sigs:master Dec 18, 2018
@M00nF1sh M00nF1sh deleted the docs-fix branch January 11, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkraig bigkraig Awaiting requested review from bigkraig

Assignees

@bigkraig bigkraig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any way to specify healthCheckPath and healthCheckStatus on a per path basis?
3 participants
@M00nF1sh @k8s-ci-robot @bigkraig