Skip to content

Bump aws-sdk-go version to v1.16.11 to support kube-aws-iam-controller #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tsub
Copy link

@tsub tsub commented Dec 22, 2018

I would like to use kube-aws-iam-controller for IAM authentication of aws-alb-ingress-controller.

But kube-aws-iam-controller requires aws-sdk-go >=v1.16.2.
So aws-sdk-go has been updated to the latest version.

I executed the following command.

$ GO111MODULE=on go get -u github.com/aws/aws-sdk-go
$ scripts/gen_mocks.sh

And I checked CHANGELOG in aws/aws-sdk-go@v1.15.39...v1.16.11

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @tsub. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 22, 2018
@tsub tsub force-pushed the support-kube-aws-iam-controller branch from cae4685 to 2d22361 Compare December 22, 2018 15:25
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 22, 2018
@tsub tsub changed the title Support kube-aws-iam-controller Bump aws-sdk-go version to v1.16.11 to support kube-aws-iam-controller Dec 23, 2018
@leakingtapan
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2019
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

/retest

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

@tsub
Sorry for the late reply(just come back from a trip)
Would you help fix the lint issue(should be pretty easy by change from endpoints.ACMServiceID to acm.EndpointsID, and similar for endpoints.WafRegionalServiceID

@tsub tsub force-pushed the support-kube-aws-iam-controller branch from aafbb2e to 58cc05e Compare January 7, 2019 04:55
@tsub
Copy link
Author

tsub commented Jan 7, 2019

@M00nF1sh Fixed in 58cc05e

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, tsub

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 370f7df into kubernetes-sigs:master Jan 7, 2019
@tsub tsub deleted the support-kube-aws-iam-controller branch January 8, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants