-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add support for multiple certificates #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
excellent. I'm evaluating options for multiple SSL cert with Kubernetes so google brought me here. I have never used aws-alb-ingress-controller before. This is merged, does that mean it's available in the helm chart already? |
Hi,
|
Amazing, thank you! |
If I understand this correctly, you need to manually create certificates in order to be able to use this. Are you planning on automating certification? I am running my cluster with EKS and Route53... |
Works brilliantly! I just tested it now |
Add support for multiple certificates
Fix #495
Action Required:
alb.ingress.kubernetes.io/certificate-arn
annotation.Semantics of
alb.ingress.kubernetes.io/certificate-arn
changed as below: