Skip to content

add support for multiple certificates #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2019
Merged

add support for multiple certificates #818

merged 2 commits into from
Jan 18, 2019

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Jan 17, 2019

Add support for multiple certificates
Fix #495

Action Required:

  • If customer manually added multiple certificates to ALB, now he needs to add the additional certificateARNs via alb.ingress.kubernetes.io/certificate-arn annotation.

Semantics of alb.ingress.kubernetes.io/certificate-arn changed as below:

  1. it's extended to support denote multiple certificates as an comma-separated list.
  2. the first certificated in the list will be the default cert on listener(will be served if no cert matching host name exists)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from bigkraig January 17, 2019 21:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2019
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@M00nF1sh M00nF1sh changed the title [WIP]add support for multiple certificates add support for multiple certificates Jan 18, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 87bef3e into kubernetes-sigs:master Jan 18, 2019
@Vince-Cercury
Copy link

excellent. I'm evaluating options for multiple SSL cert with Kubernetes so google brought me here. I have never used aws-alb-ingress-controller before.

This is merged, does that mean it's available in the helm chart already?

@M00nF1sh
Copy link
Collaborator Author

M00nF1sh commented Jan 18, 2019

excellent. I'm evaluating options for multiple SSL cert with Kubernetes so google brought me here. I have never used aws-alb-ingress-controller before.

This is merged, does that mean it's available in the helm chart already?

Hi,
Are you running clusters in AWS? this controller will only work in aws environment.
I'll release an new version v1.1.1 to include this change later today
Then you will be able to install it via

helm install incubator/aws-alb-ingress-controller  --set autoDiscoverAwsRegion=true --set autoDiscoverAwsVpcID=true --set clusterName=MyClusterName --set image.tag=v1.1.1

@FabianFrank
Copy link

Amazing, thank you!

@exolab
Copy link

exolab commented Feb 6, 2019

If I understand this correctly, you need to manually create certificates in order to be able to use this.

Are you planning on automating certification? I am running my cluster with EKS and Route53...

@AdeOpe
Copy link

AdeOpe commented Mar 17, 2019

Works brilliantly! I just tested it now
Thanks @M00nF1sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants