Skip to content

add initial set of e2e test #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019
Merged

add initial set of e2e test #852

merged 1 commit into from
Feb 19, 2019

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Feb 15, 2019

The purpose of this PR:

  1. bump dependencies to k8s v1.13.1
  2. add an e2e test launcher script(build/push to ecr, launch kops cluster)
  3. add an e2e test framework(inspired by k8s's framework but simplified), the original k8s framework brings-in all k8s dependencies, and some of them don't work under go module 😞
  4. add an initial set of e2e test cases(Fix Add E2E tests on KOPS for ALB Ingress Controller #856 ), which covers mode-ip and mode-instance under an kops cluster.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2019
@M00nF1sh M00nF1sh changed the title [WIP] add initial set of e2e test add initial set of e2e test Feb 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2019

@M00nF1sh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-aws-alb-ingress-controller-test 9b307656dd73f4b41c47eb134777805c1ea54254 link /test pull-aws-alb-ingress-controller-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@M00nF1sh M00nF1sh closed this Feb 19, 2019
@M00nF1sh M00nF1sh reopened this Feb 19, 2019
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit f7b8011 into kubernetes-sigs:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants