Skip to content

fix issue 838 #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

fix issue 838 #857

merged 1 commit into from
Feb 19, 2019

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Feb 19, 2019 •
edited
Loading

Fix #838
Changes done:

  1. cap delete securityGroup API call to 2 minutes with 2 sec interval (eventually consistency beyonds 2 minutes will be handled by controller-level backoff). (tests in my env reveals that the instance SG successfully deleted after detached from ENI imediately and the LB sg requires about 2 sec latency).
  2. handle cases when ENI is not attached to cluster but have managed SG attached.(caused by CNI bug Leaking Network Interfaces (ENI) aws/amazon-vpc-cni-k8s#69)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2019
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit fda8e40 into kubernetes-sigs:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkraig bigkraig Awaiting requested review from bigkraig

Assignees

@bigkraig bigkraig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M00nF1sh @k8s-ci-robot @bigkraig