Skip to content

Fix UT failure due to coverall #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix UT failure due to coverall #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ require (
github.com/imdario/mergo v0.3.7
github.com/json-iterator/go v1.1.5 // indirect
github.com/magiconair/properties v1.8.0
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.1 // indirect
github.com/onsi/ginkgo v1.7.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ github.com/mattn/go-colorable v0.0.9/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaO
github.com/mattn/go-isatty v0.0.3 h1:ns/ykhmWi7G9O+8a448SecJU3nSMBXJfqQkl0upE1jI=
github.com/mattn/go-isatty v0.0.3/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4=
github.com/mattn/goveralls v0.0.2/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486 h1:Wm8cZ6zwoV7jgpZl3YUSw+3Nx9BIaIQAVBCdvSZuweM=
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
github.com/mitchellh/go-homedir v1.0.0 h1:vKb8ShqSby24Yrqr/yDYkuFz8d0WUjys40rvnGC8aR0=
Expand Down
5 changes: 3 additions & 2 deletions scripts/ci_unit_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ set -e
COVER_PROFILE=profile.cov

report_coverage() {
go get github.com/mattn/goveralls
CIRCLE_BUILD_NUM=${BUILD_ID} CIRCLE_PR_NUMBER=${PULL_NUMBER} $(go env GOBIN)/goveralls \
go install -v github.com/mattn/goveralls
# need to override prow's BUILD_NUMBER to "" so it won't be reported as jobID to avoid 5xx error :D
BUILD_NUMBER="" PULL_REQUEST_NUMBER=${PULL_NUMBER} $GOBIN/goveralls \
-coverprofile=$COVER_PROFILE \
-service=prow \
-repotoken $(cat /etc/coveralls-token/k8s-aws-alb-ingress-coveralls-token) \
Expand Down