Skip to content

Commit 4f97134

Browse files
Cleanup commented sections
1 parent 7d4b41e commit 4f97134

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

pkg/log/zap/flags.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,17 +106,6 @@ func (ev *timeEncoderFlag) Type() string {
106106
}
107107

108108
func (ev *timeEncoderFlag) Set(flagValue string) error {
109-
/*val := strings.ToLower(flagValue)
110-
var timeEnc zapcore.TimeEncoder
111-
switch val {
112-
case "iso8601", "rfc3339", "rfc3339nano", "millis", "nanos", "epoch":
113-
if err := timeEnc.UnmarshalText([]byte(val)); err != nil {
114-
return fmt.Errorf("not able to unmarshal time encoder value \"%s\"", val)
115-
}
116-
ev.setFunc(timeEnc)
117-
default:
118-
return fmt.Errorf("invalid time encoder value \"%s\"", flagValue)
119-
}*/
120109
ev.setFunc(newTimeEncoder(flagValue))
121110
ev.value = flagValue
122111
return nil

pkg/log/zap/zap.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import (
3131
)
3232

3333
var encVal encoderFlag
34-
var timeEncVal timeEncoderFlag
3534

3635
// New returns a brand new Logger configured with Opts. It
3736
// uses KubeAwareEncoder which adds Type information and
@@ -241,7 +240,7 @@ func (o *Options) BindFlags(fs *flag.FlagSet) {
241240
"Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)")
242241

243242
// Set TimeEncoder value
244-
//var timeEncVal timeEncoderFlag
243+
var timeEncVal timeEncoderFlag
245244
timeEncVal.setFunc = func(fromFlag zapcore.TimeEncoder) {
246245
o.TimeEncoder = fromFlag
247246
}

0 commit comments

Comments
 (0)