cert provisioner

Author: Mengqi Yu

pkg/admission/certprovisioner/certprovisioner.go renamed to pkg/admission/certinput/certprovisioner.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package certprovisioner
+package certinput
 
 // Certs hosts a private key, its corresponding serving certificate and
 // the CA certificate that signs the serving certificate.
@@ -24,8 +24,8 @@ type Certs struct {
 	CACert []byte
 }
 
-// CertProvisioner is an interface to provision the serving certificate.
-type CertProvisioner interface {
+// CertInput is an interface to provision the serving certificate.
+type CertInput interface {
 	// ProvisionServingCert returns a Certs struct.
-	ProvisionServingCert() (*Certs, error)
+	ProvisionServingCert(CommonName string) (*Certs, error)
 }

pkg/admission/certprovisioner/certprovisioner_test.go renamed to pkg/admission/certinput/certprovisioner_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package certprovisioner
+package certinput
 
 import "fmt"
 

pkg/admission/certprovisioner/doc.go renamed to pkg/admission/certinput/doc.go

@@ -19,14 +19,12 @@ Package certprovisioner provides an interface and implementation to provision ce
 
 Create a implementation instance of certprovisioner.
 
-	cp := SelfSignedCertProvisioner{
-		CommonName: "foo.bar.com"
-	}
+	cp := SelfSignedCertInput{}
 
 Provision the certificates.
-	certs, err := cp.ProvisionServingCert()
+	certs, err := cp.ProvisionServingCert("foo.bar.com")
 	if err != nil {
 		// handle error
 	}
 */
-package certprovisioner
+package certinput

pkg/admission/certprovisioner/selfsignedcertprovisioner.go renamed to pkg/admission/certinput/selfsignedcertprovisioner.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package certprovisioner
+package certinput
 
 import (
 	"crypto/x509"
@@ -28,21 +28,18 @@ func ServiceToCommonName(serviceNamespace, serviceName string) string {
 	return fmt.Sprintf("%s.%s.svc", serviceName, serviceNamespace)
 }
 
-// SelfSignedCertProvisioner implements the CertProvisioner interface.
+// SelfSignedCertInput implements the CertInput interface.
 // It provisions self-signed certificates.
-type SelfSignedCertProvisioner struct {
-	// Required Common Name
-	CommonName string
-}
+type SelfSignedCertInput struct{}
 
-var _ CertProvisioner = &SelfSignedCertProvisioner{}
+var _ CertInput = &SelfSignedCertInput{}
 
 // ProvisionServingCert creates and returns a CA certificate, certificate and
 // key for the server. serverKey and serverCert are used by the server
 // to establish trust for clients, CA certificate is used by the
 // client to verify the server authentication chain.
 // The cert will be valid for 365 days.
-func (cp *SelfSignedCertProvisioner) ProvisionServingCert() (*Certs, error) {
+func (cp *SelfSignedCertInput) ProvisionServingCert(commonName string) (*Certs, error) {
 	signingKey, err := cert.NewPrivateKey()
 	if err != nil {
 		return nil, fmt.Errorf("failed to create the CA private key: %v", err)
@@ -57,7 +54,7 @@ func (cp *SelfSignedCertProvisioner) ProvisionServingCert() (*Certs, error) {
 	}
 	signedCert, err := cert.NewSignedCert(
 		cert.Config{
-			CommonName: cp.CommonName,
+			CommonName: commonName,
 			Usages:     []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
 		},
 		key, signingCert, signingKey,

pkg/admission/certprovisioner/selfsignedcertprovisioner_test.go renamed to pkg/admission/certinput/selfsignedcertprovisioner_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package certprovisioner
+package certinput
 
 import (
 	"crypto/x509"
@@ -24,8 +24,8 @@ import (
 
 func TestProvisionServingCert(t *testing.T) {
 	cn := "mysvc.myns.svc"
-	cp := SelfSignedCertProvisioner{CommonName: cn}
-	certs, _ := cp.ProvisionServingCert()
+	cp := SelfSignedCertInput{}
+	certs, _ := cp.ProvisionServingCert(cn)
 
 	// First, create the set of root certificates. For this example we only
 	// have one. It's also possible to omit this in order to use the