Skip to content

Commit 99e0923

Browse files
author
interma
committed
fix incorrect logr usage
1 parent 389b893 commit 99e0923

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/scaffold/controller/controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ func (r *Reconcile{{ .Resource.Kind }}) Reconcile(request reconcile.Request) (re
249249
found := &appsv1.Deployment{}
250250
err = r.Get(context.TODO(), types.NamespacedName{Name: deploy.Name, Namespace: deploy.Namespace}, found)
251251
if err != nil && errors.IsNotFound(err) {
252-
log.Info("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
252+
log.Info("Creating Deployment", "namespace", deploy.Namespace, "name", deploy.Name)
253253
err = r.Create(context.TODO(), deploy)
254254
if err != nil {
255255
return reconcile.Result{}, err
@@ -262,7 +262,7 @@ func (r *Reconcile{{ .Resource.Kind }}) Reconcile(request reconcile.Request) (re
262262
// Update the found object and write the result back if there are any changes
263263
if !reflect.DeepEqual(deploy.Spec, found.Spec) {
264264
found.Spec = deploy.Spec
265-
log.Info("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
265+
log.Info("Updating Deployment", "namespace", deploy.Namespace, "name", deploy.Name)
266266
err = r.Update(context.TODO(), found)
267267
if err != nil {
268268
return reconcile.Result{}, err

test/project/pkg/controller/firstmate/firstmate_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ func (r *ReconcileFirstMate) Reconcile(request reconcile.Request) (reconcile.Res
145145
found := &appsv1.Deployment{}
146146
err = r.Get(context.TODO(), types.NamespacedName{Name: deploy.Name, Namespace: deploy.Namespace}, found)
147147
if err != nil && errors.IsNotFound(err) {
148-
log.Info("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
148+
log.Info("Creating Deployment", "namespace", deploy.Namespace, "name", deploy.Name)
149149
err = r.Create(context.TODO(), deploy)
150150
if err != nil {
151151
return reconcile.Result{}, err
@@ -158,7 +158,7 @@ func (r *ReconcileFirstMate) Reconcile(request reconcile.Request) (reconcile.Res
158158
// Update the found object and write the result back if there are any changes
159159
if !reflect.DeepEqual(deploy.Spec, found.Spec) {
160160
found.Spec = deploy.Spec
161-
log.Info("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
161+
log.Info("Updating Deployment", "namespace", deploy.Namespace, "name", deploy.Name)
162162
err = r.Update(context.TODO(), found)
163163
if err != nil {
164164
return reconcile.Result{}, err

0 commit comments

Comments
 (0)