Skip to content

Prepare for v0.5.7 #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2020
Merged

Conversation

vincepri
Copy link
Member

This PR backports some fixes and updates from the current release to release-0.5.

vincepri and others added 5 commits June 22, 2020 08:37
This patch fixes an issue that occurs when shutting down an
envtest.Environment. If the API server fails to shutdown, then the etcd
process is orphaned. This can result in dozens of running etcd processes
when debugging failed tests.

Please see this Slack discussion for more information:
https://kubernetes.slack.com/archives/CAR30FCJZ/p1590779385006000.
Signed-off-by: ialidzhikov <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from droot and gerred June 22, 2020 15:44
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2020
@vincepri
Copy link
Member Author

/assign @alvaroaleman @detiber

@vincepri
Copy link
Member Author

@JoelSpeed This backports the log line fix we discussed last week

@vincepri vincepri added this to the v0.5.x milestone Jun 22, 2020
@detiber
Copy link
Member

detiber commented Jun 22, 2020

/lgtm
/hold
hold to allow for @alvaroaleman a chance to take a look

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 22, 2020
@alvaroaleman
Copy link
Member

Thanks!
/lgtm
/hold cancel

Sidenote, right now there is a set of features/bugfixes that only exist in a 0.5.X release but not in a 0.6.X release, I think we should do a release of the latter as well so ppl dont lose fixes by upgrading 😬

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 22691a0 into kubernetes-sigs:release-0.5 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants