Skip to content

Change other/minor emoji for PRs to 🌱 #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE/other.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- please add a :running: (`:running:`) to the title of this PR, and delete this line and similar ones -->
<!-- please add a :seedling: (`:seedling:`) to the title of this PR, and delete this line and similar ones -->

<!-- What does this do, and why do we need it? -->
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- please add a icon to the title of this PR (see VERSIONING.md), and delete this line and similar ones -->
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🏃 (:running:, other) -->
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🌱 (:seedling:, other) -->

<!-- What does this do, and why do we need it? -->
12 changes: 6 additions & 6 deletions VERSIONING.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ a:
- Non-breaking feature: :sparkles: (`:sparkles:`)
- Patch fix: :bug: (`:bug:`)
- Docs: :book: (`:book:`)
- Infra/Tests/Other: :running: (`:running:`)
- Infra/Tests/Other: :seedling: (`:seedling:`)
- No release note: :ghost: (`:ghost:`)

Use :ghost: (no release note) only for the PRs that change or revert unreleased
Expand Down Expand Up @@ -156,7 +156,7 @@ after that.

3. Add a release for controller-runtime on GitHub, using those release
notes, with a title of `vX.Y.Z`.

4. Do a similar process for
[controller-tools](https://github.com/kubernetes-sigs/controller-tools)

Expand Down Expand Up @@ -210,10 +210,10 @@ converging on a ergonomic API.

- Users will intuitively see `List`, and use that in new projects, even
if it's marked as deprecated.

- Users who don't notice the deprecation may be confused as to the
difference between `List` and `ListParametric`.

- It's not immediately obvious in isolation (e.g. in surrounding code)
why the method is called `ListParametric`, and may cause confusion
when reading code that makes use of that method.
Expand All @@ -229,8 +229,8 @@ Development branches:

- don't win us much in terms of maintenance in the case of breaking
changes (we still have to merge/manage multiple branches for development
and stable)
and stable)

- can be confusing to contributors, who often expect master to have the
latest changes.

Expand Down
8 changes: 6 additions & 2 deletions hack/release/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ cr_minor_pattern=":sparkles:|$(printf "\xe2\x9c\xa8")"
cr_patch_pattern=":bug:|$(printf "\xf0\x9f\x90\x9b")"
cr_docs_pattern=":book:|$(printf "\xf0\x9f\x93\x96")"
cr_no_release_note_pattern=":ghost:|$(printf "\xf0\x9f\x91\xbb")"
cr_other_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"
cr_all_pattern="${cr_major_pattern}|${cr_minor_pattern}|${cr_patch_pattern}|${cr_docs_pattern}|${cr_other_pattern}"
cr_other_pattern=":seedling:|$(printf "\xf0\x9f\x8f\x83")"
cr_other_old_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"
cr_all_pattern="${cr_major_pattern}|${cr_minor_pattern}|${cr_patch_pattern}|${cr_docs_pattern}|${cr_other_old_pattern}|${cr_other_pattern}"

# cr::symbol-type-raw turns :xyz: and the corresponding emoji
# into one of "major", "minor", "patch", "docs", "other", or
Expand All @@ -32,6 +33,9 @@ cr::symbol-type-raw() {
@(${cr_other_pattern})?('!'))
echo "other"
;;
@(${cr_other_old_pattern})?('!'))
echo "other"
;;
*)
echo "unknown"
;;
Expand Down