Skip to content

Prepare for v0.5.9 #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 22, 2020
Merged

Prepare for v0.5.9 #1061

merged 11 commits into from
Jul 22, 2020

Conversation

vincepri
Copy link
Member

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 22, 2020
@alvaroaleman
Copy link
Member

@vincepri the graceful shutdown PR means that we now block when we didn't. Would it make sense to default the waitPeriod to 0 seconds for reelase-0.5 to keep the behavior consistent while still allowing to opt into the feature?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 22, 2020
@vincepri
Copy link
Member Author

@alvaroaleman Removed the graceful shutdown commits, given that it was built on top of other commits that can't be backported (metrics server, leader election changes)

alvaroaleman and others added 10 commits July 22, 2020 09:05
@alvaroaleman @vincepri
🏃 Disable golangs parallel testing
2d0429d 
According to onsi/ginkgo#280 this doesn't seem
to be properly supported. If we want parallelization, we should use
ginkgos built-in mechanism for that.
@tanjunchen @vincepri
feat:Remove master word from our codebase
11c35b0
@tanjunchen @vincepri
feat:remove the whitelist word from our codebase
034e8b9
@jdef @vincepri
🐛 Better UserAgent for leader-election client (kubernetes-sigs#981)
39554bd 
* better UserAgent for leader-election client

* fixup
@joelanford @vincepri
pkg/predicate.go: add And and Or predicates
2753e3d
@nikhita @vincepri
Remove inactive members from OWNERS_ALIASES
e781fa5 
As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes totherme from
the OWNERS_ALIASES file.
@jdef @vincepri
optionally override leader election client config
a148298
@vincepri
✨ Add IsZero method to reconcile.Result
2e62791 
Signed-off-by: Vince Prignano <[email protected]>
@alexeldeib @vincepri
🏃 add apidiff to verify.sh
0678d87
@alexeldeib @vincepri
🏃 don't use apidiff on dirty commits
fef9483
@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@vincepri vincepri added this to the v0.5.x milestone Jul 22, 2020
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-release-0-5

@vincepri
Copy link
Member Author

/retest

@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-release-0-5

@vincepri
Remove -race from testing in 0.5
7e15b24 
Signed-off-by: Vince Prignano <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@alvaroaleman
Copy link
Member

/retest

@vincepri
Copy link
Member Author

Yay finally passed 🎉

@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 533c684 into kubernetes-sigs:release-0.5 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz Awaiting requested review from alenkacz

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.
8 participants
@vincepri @k8s-ci-robot @alvaroaleman @tanjunchen @jdef @joelanford @nikhita @alexeldeib