Skip to content

🌱 Give more time for prow / goroutine leak test #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🌱 Give more time for prow / goroutine leak test #1063

wants to merge 1 commit into from

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from droot and gerred July 22, 2020 23:00
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2020
@vincepri vincepri force-pushed the eventually-goroutines branch from 3d9ec65 to 4506d11 Compare July 22, 2020 23:01
@vincepri
Copy link
Member Author

Seems with these changes we can make more progress

/assign @alvaroaleman

@vincepri vincepri added this to the v0.6.x milestone Jul 22, 2020
@alvaroaleman
Copy link
Member

/test pull-controller-runtime-test-master

@alvaroaleman
Copy link
Member

Failed on second try :( I think we should just put it into a dedicated file, give it its own build tag and do a dedicated go run invocation to prevent other tests from interfering

@vincepri
Copy link
Member Author

It got closer 😂 !

@vincepri
Copy link
Member Author

@alvaroaleman Let's see if this + the updated CPU requests work out better

@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

1 similar comment
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

@vincepri
Copy link
Member Author

Closing in favor of #1070

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closed this PR.

In response to this:

Closing in favor of #1070

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@droot droot Awaiting requested review from droot

@gerred gerred Awaiting requested review from gerred

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@vincepri @k8s-ci-robot @alvaroaleman