Skip to content

Bump to Kubernetes 1.19-rc.3 #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Bump to Kubernetes 1.19-rc.3 #1068

merged 1 commit into from
Aug 4, 2020

Conversation

joelanford
Copy link
Member

This PR bumps controller-runtime dependencies to Kubernetes 1.19.

Note that Kubernetes 1.19 is not GA yet. This PR will be updated when it is GA.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2020
@rifelpet rifelpet mentioned this pull request Jul 28, 2020
Merged
@rifelpet
Copy link

rifelpet commented Jul 30, 2020 •
edited
Loading

Hi @joelanford, is there any chance this could get merged sooner than 1.19.0 stable being released? Theres a breaking change in github.com/go-logr/logr v0.2.0 that is making it difficult for users to upgrade their kubernetes dependencies to the 1.19 prereleases without controller-runtime also having logr updated to 0.2.0.

Merging this would allow us (Kops) to bump our controller-runtime dependency to the latest master commit and update all kubernetes dependencies to the latest 1.19 RC. This allows us to get CI signal with 1.19 without having to wait for 1.19.0 stable to be released. When it is released we could update controller-runtime's dependencies once more and follow the normal release process.

For more info see go-logr/logr#20 (and the linked issue) and the build failures here and here.

@joelanford
Copy link
Member Author

is there any chance this could get merged sooner than 1.19.0 stable being released?

@rifelpet there was discussion at yesterday's kubebuilder/controller-runtime/controller-tools community meeting about doing exactly this.

The decision was that we could merge this PR prior to GA, but then not cut the release for v0.7.0 until we update to the GA deps.

I think we decided to make another few non-breaking changes on master so that we can cut another v0.6.x release to avoid some backports.

I'll update this PR again to the latest 1.19 deps.

/cc @vincepri @DirectXMan12

@alvaroaleman
Copy link
Member

Can we use a go-logr version that has go-logr/logr#20 ?

@joelanford joelanford changed the title [WIP] ⚠ bump to kubernetes 1.19 ⚠ bump to kubernetes 1.19 Jul 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@alvaroaleman
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2020
@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

/retest

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 4, 2020 •
edited
Loading

@joelanford: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-controller-runtime-apidiff-master 17eebbf link /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020
vincepri
vincepri approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020
@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/retitle Bump to Kubernetes 1.19-rc.3

@k8s-ci-robot k8s-ci-robot changed the title ⚠ bump to kubernetes 1.19 Bump to Kubernetes 1.19-rc.3 Aug 4, 2020
@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

Removing the ⚠️, given that I expect we update to 1.19.0/1 and that should go in the actual release notes

@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/milestone v0.7.x

@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Aug 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4fcd09c into kubernetes-sigs:master Aug 4, 2020
@alvaroaleman alvaroaleman mentioned this pull request Aug 4, 2020
Closed
@joelanford joelanford deleted the k8s-1.19 branch August 4, 2020 21:21
@shamsher31 shamsher31 mentioned this pull request Aug 27, 2020
Merged
rhrazdil pushed a commit to rhrazdil/kubemacpool that referenced this pull request Sep 18, 2020
Bump github.com/go-logr/logr to v0.2.1
80771f7 
Due to breaking changes in go-logr, used specific hash.
See kubernetes-sigs/controller-runtime#1068
for reference

Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil pushed a commit to rhrazdil/kubemacpool that referenced this pull request Sep 18, 2020
Bump github.com/go-logr/logr to v0.2.1
d0c15be 
Due to breaking changes in go-logr, used specific hash.
See kubernetes-sigs/controller-runtime#1068
for reference

Signed-off-by: Radim Hrazdil <[email protected]>
kubevirt-bot pushed a commit to k8snetworkplumbingwg/kubemacpool that referenced this pull request Sep 21, 2020
@rhrazdil
Bump kubemacpool deps (#244)
71b8cb0 
* Bump kubernetes to v0.19.1

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump github.com/go-logr/logr to v0.2.1

Due to breaking changes in go-logr, used specific hash.
See kubernetes-sigs/controller-runtime#1068
for reference

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump github.com/mattn/goveralls to v0.0.7

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump gingko and gomega

gingko to v1.14.1
gomega to v1.10.2

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump sigs.k8s.io/controller-runtime to v0.6.2

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump sigs.k8s.io/controller-tools to v0.4.0

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump CNAO to v1

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump kubevirtci to k8s-1.19

Signed-off-by: Radim Hrazdil <[email protected]>

* Bump kubevirt to v0.33.0

Signed-off-by: Radim Hrazdil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@vincepri vincepri

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging this pull request may close these issues.
5 participants
@joelanford @k8s-ci-robot @rifelpet @alvaroaleman @vincepri