Clarify SyncPeriod comment #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the advice about when to change, since sync period is more subtle than can be explained in a comment. Replaces it with a warning to know what you're doing before changing it.
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
FYI this isn't picking up @DirectXMan12's /approve because the OWNERS_ALIASES file that his rights should be coming from has syntax errors Compare the sample to the actual file used in this repo |
|
Ok, fix merged, let's try again /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, grantr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…ment Clarify SyncPeriod comment
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Rename 'validation' generation to CRD generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the advice about when to change, since sync period is more subtle than can be explained in a comment. Replaces it with a warning to know what you're doing before changing it.
Followup from the conversation with @DirectXMan12 in #88.