🐛 Test can inspect stdout & stderr: Give some time to exit

[alvaroaleman]

Hopefully will fix our top failing test. I believe it is failing because we expect it to be exited immediately after it started. However it might need a bit more time after printing the successful start message to be exited.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/internal/testing/OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

/test pull-controller-runtime-test-master

[alvaroaleman]

/test pull-controller-runtime-test-master

[alvaroaleman]

/test pull-controller-runtime-test-master

[alvaroaleman]

/test pull-controller-runtime-test-master

[alvaroaleman]

/test pull-controller-runtime-test-master

[alvaroaleman]

The job failed one out of five times and that because of a different error so I think this PR definitely improves the situation: https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=controller-runtime&pr=1077

/assign @vincepri

[vincepri]

Should we increase the eventually global timeout, to something like 10-20 seconds?

[vincepri]

SetDefaultEventuallyPollingInterval(100 * time.Millisecond)
SetDefaultEventuallyTimeout(30 * time.Second)

This is what we use in Cluster API

[alvaroaleman]

@vincepri hmhm, so if possible I would prefer to only do that on individual testcases when we know they need that (does ginkgo allow that?)

[vincepri]

Yeah, that would be the second argument of Eventually

[alvaroaleman]

@vincepri yeah then I would be in favor of just doing that when we see a need rather than globally

[alvaroaleman]

@vincepri can we merge this or is there something unaddressed left?

[vincepri]

/lgtm