Skip to content

Updating to k8s 1.11. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2018
Merged

Conversation

n3wscott
Copy link

@n3wscott n3wscott commented Aug 13, 2018

Some things changed between 1.10 to 1.11:

  • apimachinery removed pkg/types/NewNamespacedNameFromString
  • using mapping.Resource now requires mapping.Resource.String()
  • GetAPIGroupResources was moved from discovery to restmapper
  • discovery.NewRESTMapper moved to restmapper.NewDiscoveryRESTMapper

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 13, 2018
@n3wscott
Copy link
Author

Not sure what you folks run to trim the source to fix the error. Let me know and I can update.

@DirectXMan12
Copy link
Contributor

Yeah, sorry about that. The error message is terrible. Run goimports -w path/to/the/file to autofix the issues.

@n3wscott
Copy link
Author

I am not able to run the unit tests locally on a mac.

…ow we have to ask for the resource directly.
@n3wscott
Copy link
Author

n3wscott commented Aug 13, 2018

I am not able to run the unit tests locally on a mac.

I had to install kubebuilder under /usr/local/kubebuilder.

@grantr
Copy link
Contributor

grantr commented Aug 14, 2018

I had to install kubebuilder under /usr/local/kubebuilder.

I ran into the same thing in #90.

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 741f067 into kubernetes-sigs:master Aug 14, 2018
@DirectXMan12
Copy link
Contributor

We're going to have to (temporarily) revert this due to the way kubebuilder currently deals with deps. We're going to start the whole update process and make sure we have it documented in the future to avoid mishaps.

@n3wscott
Copy link
Author

No problem, any way to reopen the or or do I have to?

justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Add link to CRD docs to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants