Skip to content

Update OWNERS_ALIASES to fix approver bot #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Update OWNERS_ALIASES to fix approver bot #109

merged 1 commit into from
Aug 13, 2018

Conversation

DirectXMan12
Copy link
Contributor

The OWNERS_ALIASES needs aliases as map keys, not as list items.

@DirectXMan12
Update OWNERS_ALIASES to fix approver bot
7794610 
The OWNERS_ALIASES needs aliases as map keys, not as list items.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2018
@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Aug 13, 2018 •
edited
Loading

@droot @pwittrock FYI

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2018
@DirectXMan12
Copy link
Contributor Author

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DirectXMan12
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DirectXMan12 DirectXMan12 merged commit 136e9e1 into kubernetes-sigs:master Aug 13, 2018
@DirectXMan12 DirectXMan12 deleted the infra/fix-owners-aliases branch August 13, 2018 17:01
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@DirectXMan12
Merge pull request kubernetes-sigs#109 from DirectXMan12/infra/fix-ow…
e994e88 
…ners-aliases

Update OWNERS_ALIASES to fix approver bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DirectXMan12 @k8s-ci-robot